Hi Ben, Thanks for the feedback. I will work around the "caller" by changing #!/bin/sh to #!/bin/bash
As for the parent process, I think it depends on how verbose people consider the information helpful. The current patch only adds the immediate caller, but we could definitely add the entire call stack within the same process, or like you suggest, add the parent process. Regards, William On Tue, Dec 22, 2015 at 11:18 PM, Ben Pfaff <[email protected]> wrote: > On Tue, Dec 22, 2015 at 01:56:55PM -0800, William Tu wrote: > > The patch adds the caller's information of ovs_vsctl() in order > > to assist debugging. The caller's information is formatted as > > "(filename, line number)". > > > > An example: > > > ovsdb-tool show-log > > record 183: 2015-12-22 21:12:26.050 "ovs-vsctl: ovs-vsctl --no-wait > > add-br br0 -- comment (FILE:./ifupdown.sh,LINE:81)" > > This looks useful but as-is the ifupdown.sh code appears bash-specific, > because I don't think "caller" is POSIX. You can probably work around > that by checking for bash, or by changing #!/bin/sh to #!/bin/bash since > this is Debian-specific anyway. > > You could get most of the benefit of this change by modifying ovs-vsctl > to get the name of its parent process. That requires OS-specific code > but at least on Linux it shouldn't be difficult. It would have the > advantage that it would work for every caller not just for the ones that > the patch specifically updates. Did you consider that idea? > > Thanks, > > Ben. > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
