Numan Siddique <nusid...@redhat.com> wrote on 06/01/2016 03:26:22 PM:
>
> +        elif "modify" in row_update:
> +            if not row:
> +                raise error.Error('Modify non-existing row')
> +
> +            self.notify(ROW_UPDATE, row,
> +                        Row.from_json(self, table,
> +                                      uuid, row_update['modify']))
> 
> I think notify should be called after applying the diff and the last
> parameter 'updates' to the notify function should be a row object
> with old values of the modified columns.
> 

Right, notify() should be called after __apply_diff() and updates should 
be Row object with only the changed columns.
Will fix that in the next version.

Thanks.

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to