Dear Aaron,
I completely agree with you, I've sent a second version:
http://openvswitch.org/pipermail/dev/2016-January/064228.html
Thank you very much,
Mauricio Vasquez B
On 10 January 2016 at 12:17, Aaron Conole <acon...@bytheb.org> wrote:
> Greetings Mauricio,
>
> Mauricio Vasquez B <mauricio.vasquezber...@studenti.polito.it> writes:
> > A ring name length of 10 characters is not enough for dpdkr ports
> > starting from dpdkr10, then it is increased to 20 characters.
> >
> > Signed-off-by: Mauricio Vasquez B <
> mauricio.vasquezber...@studenti.polito.it>
> > ---
> > lib/netdev-dpdk.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> > index b209df2..60c4262 100644
> > --- a/lib/netdev-dpdk.c
> > +++ b/lib/netdev-dpdk.c
> > @@ -1921,7 +1921,7 @@ dpdk_ring_create(const char dev_name[], unsigned
> int port_no,
> > unsigned int *eth_port_id)
> > {
> > struct dpdk_ring *ivshmem;
> > - char ring_name[10];
> > + char ring_name[20];
>
> I think here it would be better to use ``RTE_RING_NAMESIZE`` rather than
> the constant 20.
>
> Thanks,
> -Aaron
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
