On 29 January 2016 at 15:54, pravin shelar <pshe...@ovn.org> wrote: > On Mon, Jan 11, 2016 at 5:53 PM, Joe Stringer <j...@ovn.org> wrote: >> Broadly, for the conntrack and ip_fragment backport in the OVS tree, we have >> until now depended on a macro to include the entire backport based on kernel >> version. Any kernel that the backport is compiled against from version v3.10 >> up >> to v4.3 ends up using the backported version of all functions, rather than >> making use of the upstream functions as much as possible. >> >> This approach is a little different from what the remainder of the OVS >> backport >> code does, where upstream code is used as much as possible. Particularly with >> future kernels, it is better for us to rely on the upstream functionality >> rather than always backporting the version in the tree. >> >> In future we anticipate different combinations of this functionality being >> backported into distribution kernels, which makes these version checks less >> reliable for finding the actual functionality available in the host kernel. >> >> This series removes all of the existing version checks in the >> conntrack/fragment backport code in favour of checks for individual >> functions. >> I propose backporting these to branch-2.5 as well, to make it more likely >> that >> the v2.5 release will continue to work with updated distribution kernels as >> they are released (or at least, less work to fix it later). >> > Overall I like this series. Assuming you will fix one issue that I > commented on patch 7. I am fine with this series going in. > > Acked-by: Pravin B Shelar <pshe...@ovn.org>
Thanks for the review. I checked back across the series and noticed a couple of issues with some of the patches on particular ubuntu kernels; I pushed most of the patches (master+branch-2.5), but a couple of them needed some changes and there is a new related patch that fixes an unrelated backport issue. I will send a v2 for those. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
