On Sat, Feb 06, 2016 at 03:45:29PM +0530, Numan Siddique wrote:
> On 02/06/2016 03:01 AM, Ben Pfaff wrote:
> > However, the problem you report probably indicates a bug somewhere else,
> > because the OFPT_SET_CONFIG message is generated from the
> > OFPT_GET_CONFIG_REPLY sent by the switch.  If the switch rejects the
> > OFPT_SET_CONFIG, then, it could mean that the OFPT_GET_CONFIG_REPLY that
> > it generated was invalid.  If true, I'd like to fix that.  Can you tell
> > me how to see the error?  Plain "make sandbox SANDBOXFLAGS=--ovn" didn't
> > make it manifest, for me.
> 
> I am able to reproduce the issue by running the below commands
> 
> $make sandbox SANDBOXFLAGS="--ovn"
> $ovn/env1/setup.sh
> $ovs-ofctl add-flow br-int "table=0, priority=200, in_port=2, 
> action=controller"
> $src_mac=000000000002
> $request=ffffffffffff${src_mac}080045100110000000008011000000000000ffffffff0044004300FC0000
> $ovs-appctl ofproto/trace br-int in_port=2 $request
> 
> 
> Before calling set_switch_config(swconn, &config) in ovn/controller/pinctrl.c 
> at L108
> (https://github.com/openvswitch/ovs/blob/master/ovn/controller/pinctrl.c#L108),
>  If I set
> config.flags = 0; ovn-controller is getting the packet-in message from the 
> Open vSwitch.

Thanks.  I found the bug and fixed it in a commit that I inserted just
before yours.  There wasn't any point in getting it reviewed because
your commit then deletes the code, so I just went ahead and applied both
to master.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to