For some reason I can’t find some to the patches in my inbox (nor in Junk mail). I applied the patches from patchwork, so this seems to be a problem with my mail.
Anyway, this is an Ack for the 1st patch: Acked-by: Jarno Rajahalme <ja...@ovn.org> The second patch fails two test cases: conjunctive match 99: conjunctive match and other actions FAILED (classifier.at:296) ofproto-dpif 846: ofproto-dpif - note at offset 24 in ofpacts FAILED (ofproto-dpif.at:781) ./classifier.at:296: ovs-ofctl add-flow br0 'actions=conjunction(3,1/2),note:41.42.43.44.45.46' --- /dev/null 2016-02-05 17:19:20.062408851 -0800 +++ /home/jrajahalme/openvswitch/tests/testsuite.dir/at-groups/99/stderr 2016-02-10 15:08:44.139391939 -0800 @@ -0,0 +1,2 @@ +ovs-ofctl: lib/ofp-actions.c:7265: assertion ofpact == ofpacts->header failed in ofpact_finish() +/home/jrajahalme/openvswitch/tests/testsuite.dir/at-groups/99/test-source: line 251: 121370 Aborted (core dumped) ovs-ofctl add-flow br0 'actions=conjunction(3,1/2),note:41.42.43.44.45.46' ./classifier.at:296: exit code was 134, expected 0 ./ofproto-dpif.at:781: ovs-ofctl add-flows br0 flows.txt --- /dev/null 2016-02-05 17:19:20.062408851 -0800 +++ /home/jrajahalme/openvswitch/tests/testsuite.dir/at-groups/846/stderr 2016-02-10 15:08:44.947371022 -0800 @@ -0,0 +1,2 @@ +ovs-ofctl: lib/ofp-actions.c:7265: assertion ofpact == ofpacts->header failed in ofpact_finish() +/home/jrajahalme/openvswitch/tests/testsuite.dir/at-groups/846/test-source: line 202: 121938 Aborted (core dumped) ovs-ofctl add-flows br0 flows.txt ./ofproto-dpif.at:781: exit code was 134, expected 0 Jarno > On Feb 9, 2016, at 10:10 PM, Ben Pfaff <b...@ovn.org> wrote: > > This is the third revision of my "closures" patch. > > The first version was: > http://openvswitch.org/pipermail/dev/2016-January/064607.html > > The second version, unfortunately not marked v2, was: > https://patchwork.ozlabs.org/patch/574946/ > and the v1->v2 changes were described at: > http://openvswitch.org/pipermail/dev/2016-January/064875.html > > Changes v2->v3: > - Patches 1 through 6 are new. > - There's a terminology change starting in patch 6. Now the process > of pausing translation is called "freezing", and there are two users > of freezing, which are recirculation and closures. > - I added the ability to provide arbitrary user data on NXAST_PAUSE > which is passed to the controller in a property on NXT_CLOSURE. > - I made all the changes described in: > http://openvswitch.org/pipermail/dev/2016-February/065984.html > - I added a few more tests to ofp-print.at and ofp-actions.at. > - Probably other refinements I've forgotten. > > Ben Pfaff (7): > dynamic-string: Make ds_chomp() return true if it removed a character. > ofpbuf: Make ofpbuf_put_hex() accept period between hex bytes also. > ofproto-dpif-xlate: Improve recirc_unroll_actions() interface. > ofproto-dpif-xlate: New helper function ctx_cancel_recirculation(). > ofproto-dpif-xlate: Break recirculation actions out from action_set. > ofproto-dpif-xlate: Distinguish "freezing" from "recirculation". > Implement "closures". > > NEWS | 4 + > include/openflow/nicira-ext.h | 100 ++++++++- > lib/dynamic-string.c | 7 +- > lib/dynamic-string.h | 4 +- > lib/meta-flow.c | 9 +- > lib/meta-flow.h | 3 +- > lib/ofp-actions.c | 174 ++++++++++++--- > lib/ofp-actions.h | 13 +- > lib/ofp-errors.h | 15 +- > lib/ofp-msgs.h | 8 + > lib/ofp-print.c | 81 +++++++ > lib/ofp-util.c | 362 +++++++++++++++++++++++++++++++ > lib/ofp-util.h | 60 +++++- > lib/ofpbuf.c | 12 +- > lib/rconn.c | 4 +- > ofproto/connmgr.c | 70 ++++-- > ofproto/connmgr.h | 3 + > ofproto/ofproto-dpif-xlate.c | 485 +++++++++++++++++++++++++----------------- > ofproto/ofproto-dpif-xlate.h | 4 + > ofproto/ofproto-dpif.c | 35 +++ > ofproto/ofproto-provider.h | 3 + > ofproto/ofproto.c | 25 +++ > tests/ofp-actions.at | 18 ++ > tests/ofp-print.at | 34 +++ > tests/ofproto-dpif.at | 174 +++++++++++++++ > tests/ofproto-macros.at | 35 ++- > tests/ofproto.at | 2 + > utilities/ovs-ofctl.8.in | 32 ++- > utilities/ovs-ofctl.c | 111 +++++++--- > vswitchd/vswitch.xml | 17 +- > 30 files changed, 1603 insertions(+), 301 deletions(-) > > -- > 2.1.3 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
