> On Feb 11, 2016, at 5:18 PM, Ramu Ramamurthy <[email protected]>
> wrote:
I'll let Russell do the full review, but I had one other small suggestion from
looking at the code:
> @@ -72,13 +75,65 @@ get_local_iface_ids(const struct ovsrec_bridge *br_int,
> struct shash *lports)
> continue;
> }
> shash_add(lports, iface_id, iface_rec);
> + zone = smap_get(&iface_rec->external_ids, "ovn-zone-id");
> + if (zone && ovs_scan(zone, "%d", &zone_id)) {
Instead of going through ovs_scan(), can you simplify this logic by just
calling smap_get_int()?
--Justin
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev