Oh, that's a completely different test failure. I'm sure it's less
mysterious. Probably I introduced it somewhere in revision today.
I see it now too, I'll fix it.
The test failure I had a problem with is:
1751: ovn -- 3 HVs, 3 LS, 3 lports/LS, 1 LR
On Fri, Feb 19, 2016 at 04:17:42PM -0800, Jarno Rajahalme wrote:
> I’ve reviewed the series unto this point. Maybe someone else will review the
> OVN patches. I did note, however, that the last patch does not help the test
> failure:
>
> Before the last patch:
>
> # put_arp
> -actions=push:NXM_NX_REG1[],push:NXM_OF_ETH_SRC[],push:NXM_NX_ARP_SHA[],push:NXM_OF_ARP_SPA[],pop:NXM_NX_REG1[],pop:NXM_OF_ETH_SRC[],push:NXM_NX_REG0[],set_field:0xbd9c9810->reg0,controller(reason=packet_out),pop:NXM_NX_REG0[],pop:NXM_OF_ETH_SRC[],pop:NXM_NX_REG1[],
> prereqs=eth.type == 0x806 && eth.type == 0x806
> +actions=push:NXM_NX_REG0[],push:NXM_OF_ETH_SRC[],push:NXM_NX_ARP_SHA[],push:NXM_OF_ARP_SPA[],pop:NXM_NX_REG0[],pop:NXM_OF_ETH_SRC[],controller(userdata=01.00.00.00.00.00.00.00),pop:NXM_OF_ETH_SRC[],pop:NXM_NX_REG0[],
> prereqs=eth.type == 0x806 && eth.type == 0x806
>
> After the last patch:
>
> # put_arp
> -actions=push:NXM_NX_REG1[],push:NXM_OF_ETH_SRC[],push:NXM_NX_ARP_SHA[],push:NXM_OF_ARP_SPA[],pop:NXM_NX_REG1[],pop:NXM_OF_ETH_SRC[],push:NXM_NX_REG0[],set_field:0xbd9c9810->reg0,controller(reason=packet_out),pop:NXM_NX_REG0[],pop:NXM_OF_ETH_SRC[],pop:NXM_NX_REG1[],
> prereqs=eth.type == 0x806 && eth.type == 0x806
> +actions=push:NXM_NX_REG0[],push:NXM_OF_ETH_SRC[],push:NXM_NX_ARP_SHA[],push:NXM_OF_ARP_SPA[],pop:NXM_NX_REG0[],pop:NXM_OF_ETH_SRC[],controller(userdata=01.00.00.00.00.00.00.00),pop:NXM_OF_ETH_SRC[],pop:NXM_NX_REG0[],
> prereqs=eth.type == 0x806 && eth.type == 0x806
>
> I.e., the same.
>
> I hope I did not ack the bug causing this..
>
> Jarno
>
> > On Feb 19, 2016, at 3:00 PM, Joe Stringer <j...@ovn.org> wrote:
> >
> > On 19 February 2016 at 00:34, Ben Pfaff <b...@ovn.org> wrote:
> >> An upcoming commit will add another case where it's desirable to ensure
> >> that a variable-length array is aligned on an 8-byte boundary. This macro
> >> makes that a little easier.
> >>
> >> Signed-off-by: Ben Pfaff <b...@ovn.org>
> >> CC: Joe Stringer <j...@ovn.org>
> >
> > MSVC seems happy, so I'm happy:
> > https://ci.appveyor.com/project/joestringer/openvswitch/build/1.0.24
> >
> > Acked-by: Joe Stringer <j...@ovn.org>
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
