We might need to revisit the way probing is handled. But this is good for
the time being.

Acked-by: Sairam Venugopal <vsai...@vmware.com>



On 2/22/16, 6:07 AM, "Sorin Vinturis" <svintu...@cloudbasesolutions.com>
wrote:

>Recirculation feature probe messages sent from userspace are
>suppressed by the OVS extension.
>
>This patch changes the current behaviour to allow feature probe
>for recirculation.
>
>Signed-off-by: Sorin Vinturis <svintu...@cloudbasesolutions.com>
>---
>v3: No changes from the previous version.
>---
> datapath-windows/ovsext/Flow.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/datapath-windows/ovsext/Flow.c
>b/datapath-windows/ovsext/Flow.c
>index baf8422..a481eca 100644
>--- a/datapath-windows/ovsext/Flow.c
>+++ b/datapath-windows/ovsext/Flow.c
>@@ -2625,8 +2625,15 @@ OvsProbeSupportedFeature(POVS_MESSAGE msgIn,
>             OVS_LOG_ERROR("Wrong ethertype for MPLS attribute.");
>             status = STATUS_INVALID_PARAMETER;
>         }
>+    } else if (keyAttrs[OVS_KEY_ATTR_RECIRC_ID]) {
>+        UINT32 recircId = NlAttrGetU32(keyAttrs[OVS_KEY_ATTR_RECIRC_ID]);
>+
>+        if (!recircId) {
>+            OVS_LOG_ERROR("Invalid recirculation ID.");
>+            status = STATUS_INVALID_PARAMETER;
>+        }
>     } else {
>-        OVS_LOG_ERROR("Probed feature not supported.");
>+        OVS_LOG_ERROR("Feature not supported.");
>         status = STATUS_INVALID_PARAMETER;
>     }
> 
>-- 
>1.9.0.msysgit.0
>_______________________________________________
>dev mailing list
>dev@openvswitch.org
>http://openvswitch.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to