Somehow, none of this series made it to my inbox, and only some of it
made it into patchwork. Thus, I'm probably breaking your email
threading here; sorry.
This seems at worst harmless to me. I applied it.
I'm CCing Shad, the author of the change tracking code, in case he
thinks this is wrong.
On Mon, Mar 28, 2016 at 08:43:11AM -0500, Ryan Moats wrote:
> From: RYAN D. MOATS <rmo...@us.ibm.com>
>
> Deletes need to be reordered as well as inserts and modifies,
> otherwise, following tracked changes will see out of order
> seqnos.
>
> Signed-off-by: RYAN D. MOATS <rmo...@us.ibm.com>
> ---
> lib/ovsdb-idl.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
> index bfc133b..84ce14e 100644
> --- a/lib/ovsdb-idl.c
> +++ b/lib/ovsdb-idl.c
> @@ -1589,9 +1589,10 @@ ovsdb_idl_row_destroy(struct ovsdb_idl_row *row)
> = row->table->change_seqno[OVSDB_IDL_CHANGE_DELETE]
> = row->table->idl->change_seqno + 1;
> }
> - if (list_is_empty(&row->track_node)) {
> - list_push_back(&row->table->track_list, &row->track_node);
> + if (!list_is_empty(&row->track_node)) {
> + list_remove(&row->track_node);
> }
> + list_push_back(&row->table->track_list, &row->track_node);
> }
> }
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
