On Wed, Mar 30, 2016 at 12:31:27PM -0700, pravin shelar wrote:
> On Wed, Mar 30, 2016 at 10:24 AM, William Tu <[email protected]> wrote:
> > Hi Pravin,
> >
> > Thanks for the feedback.
> > So another option is to add an new truncate action, and modify the size for
> > all the following output packets. For example, the output:1 remains the
> > original size and the output:2 and output:3 will have size 100.
> > # ovs-ofctl add-flow br0 'actions=output:1, truncate:100, output:2,
> > output:3'
> >
> > Or we can implement truncate_output action so that the truncate only scope
> > at a specific output. For example:
> > # ovs-ofctl add-flow br0 'actions=output:1, truncate_output:
> > (2,max_len=100), output:3'
> > So that only output:2 is re-sized to 100.
> >
> > Which one do you think is more useful?
> >
> The comment was about datapath action. I am fine with ofctl interface
> that you have.
The formatting/parsing syntax diverges from that for the other newer
actions we've introduced; it's kind of weird to have parenthesized
arguments following another argument.
Therefore I'd prefer something more like:
output(port=1, max_len=128)
Also, I don't think it's reasonable to reuse OFPAT_OUTPUT for this. One
simply cannot rely on every existing controller to fill something
sensible in for the max_len field. I suggest inventing a new OpenFlow
extension action. (That doesn't mean you have to change the syntax used
in ovs-ofctl; we have plenty of examples where multiple OpenFlow actions
have a common syntax.)
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
