On Wed, Apr 6, 2016 at 10:49 AM, Han Zhou <zhou...@gmail.com> wrote:

>
>
> On Wednesday, April 6, 2016, Russell Bryant <russ...@ovn.org> wrote:
>
>>
>>
>> On Wed, Apr 6, 2016 at 3:10 AM, Han Zhou <zhou...@gmail.com> wrote:
>>
>>>
>>> On Mon, Apr 4, 2016 at 5:58 AM, Russell Bryant <russ...@ovn.org> wrote:
>>> > -          Each <code>localnet</code> logical port is implemented as a
>>> pair of
>>> > -          patch ports, one in the integration bridge, one in a
>>> different
>>> > -          bridge, with the same
>>> <code>external-ids:ovn-localnet-port</code>
>>> > -          value.
>>> > +          Each <code>localnet</code> and <code>gateway</code> logical
>>> port
>>> > +          is implemented as a pair of patch ports, one in the
>>> integration
>>> > +          bridge, one in a different bridge, with the same
>>> > +          <code>external-ids:ovn-localnet-port</code> value.
>>>
>>> Is this ovn-localnet-port a typo?
>>>
>>
>> No.  It's still using the same external-id value.  I did that because
>> "gateway" ports share almost all of the code for localnet ports, so it was
>> just convenient.
>>
>> I thought about changing the name to avoid confusion, but hadn't decided
>> on exactly what to change yet.
>>
>> I think it would worth a small code change in patch.c so that they use
> different names to avoid confusion.
>

Sounds good.  It'll need some changes in physical.c, as well, I believe.

I'll work on it.  Thanks,

-- 
Russell Bryant
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to