Hello,

I'm playing littlebit with ingress policing in openvswitch and I found some 
kind of inconsistency.
In docs and in source code (https://github.com/openvswitch/ovs/blob/master/
lib/netdev-linux.c#L4698) there is info that burst is set in kilobits, but I 
found that in fact it is set in kilobytes in tc.
So long story short:

root@ubuntu-1604-test:/home/ubuntu# ovs-vsctl show
f0d1f90d-174f-47bf-89bc-bf37f2da0271
    Bridge "br1"
        Port vethA
            Interface vethA
        Port "br1"
            Interface "br1"
                type: internal
    ovs_version: "2.5.0"


root@ubuntu-1604-test:/home/ubuntu# ovs-vsctl set Interface vethA 
ingress_policing_rate=1000 -- set Interface vethA ingress_policing_burst=100

root@ubuntu-1604-test:/home/ubuntu# ovs-vsctl list interface vethA | grep 
ingress
ingress_policing_burst: 100
ingress_policing_rate: 1000


results in:
root@ubuntu-1604-test:/home/ubuntu# tc filter show dev vethA parent ffff:
filter protocol all pref 49 basic 
filter protocol all pref 49 basic handle 0x1 
 police 0x1 rate 1Mbit burst 100Kb mtu 64Kb action drop overhead 0b 
ref 1 bind 1


As You can see above, burst is given in "Kb" units what, according to tc man 
(http://lartc.org/manpages/tc.txt) means kilobytes.

So question: is it intentional inconsistency or bug? If bug then where: in 
code or in docs?

-- 
Pozdrawiam / Best regards
Sławek Kapłoński
sla...@kaplonski.pl
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to