-----Original Message----- From: Jesse Gross <je...@kernel.org> Date: Friday, April 15, 2016 at 10:40 AM To: Nithin Raju <nit...@vmware.com> Cc: Paul Boca <pb...@cloudbasesolutions.com>, "dev@openvswitch.org" <dev@openvswitch.org> Subject: Re: [ovs-dev] [PATCH 3/3] datapath-windows: Removed always true condition in VXLAN
>On Fri, Apr 15, 2016 at 10:27 AM, Nithin Raju <nit...@vmware.com> wrote: >> Paul, >> If you are sure that tunKey->tunnelId will always be set, it would be a >> good idea to mark .optional as FALSE in definition of >> nlFlowTunnelKeyPolicy. > >For tunnels in general, the key won't always be present. (GRE is an >example of where the key is optional in the protocol itself and this >is reflected in what would be received from netlink.) > >In the specific case of VXLAN, though, it is true that the instance ID >bit must always be set. Thanks for the input. That calls for more checks while adding the port and perhaps an ASSERT during VXLAN encap to make sure there¹s a valid Tunnel ID. -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
