On Fri, Apr 22, 2016 at 04:04:26PM +0200, Christian Ehrhardt wrote: > From the manpages of getgrnam_r (getpwnam_r is similar): > "If no matching group record was found, these functions return 0 and > store NULL in *result." > > The code checked only against errors, but non existing users didn't set > e != 0 therefore the code could try to set arbitrary uid/gid values. > > Fixes: e91b927d lib/daemon: support --user option for all OVS daemon > > Signed-off-by: Christian Ehrhardt <christian.ehrha...@canonical.com>
Thanks for the patch. This does not compile: ../lib/daemon-unix.c:975:18: error: invalid operands to binary expression ('struct passwd' and 'void *') ../lib/daemon-unix.c:1018:22: error: invalid operands to binary expression ('struct group' and 'void *') _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev