On Wed, Apr 27, 2016 at 06:36:03AM +0000, Daniele Di Proietto wrote: > On 26/04/2016 16:35, "Flavio Leitner" <f...@sysclose.org> wrote: > > >On Fri, Apr 15, 2016 at 05:02:35PM -0700, Daniele Di Proietto wrote: > >> The function simply returns the ethernet type of the packet (after > >> eventually discarding the VLAN tag). It will be used by a following > >> commit. > >> > >> Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> > >> --- > > > >I agree with Joe that we should avoid forcing inlining. > > > >Acked-by: Flavio Leitner <f...@sysclose.org> > > I would try to avoid forcing inlining in general, but this is done > to prevent a performance regression in miniflow_extract(). Antonio > spotted this out in v1 of the series: > > http://openvswitch.org/pipermail/dev/2016-February/065454.html > > If you guys agree, I'd be inclined to keep the ALWAYS_INLINE here.
I tried here with and without the ALWAYS_INLINE and the results are the same (perf and assembly). But since you two could reproduce the issue and it makes sense to inline those two functions, it seems okay to use ALWAYS_INLINE. Thanks, -- fbl _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
