On Wed, May 11, 2016 at 11:51:29AM -0700, Dennis Sam wrote:
> Extend the Global table to allow for additional configurations by re-using
> the idea of an other_config column.
> 
> Signed-off-by: Dennis Sam <d...@arista.com>

Seems fine to me.

> -  "version": "1.5.1"}
> +  "version": "1.5.2"}

Though it doesn't make much difference in practice, I believe that our
versioning policy calls for incrementing the middle number when adding
columns, e.g. 1.6.0 here.

The versioning policy is documented in vswitchd/vswitch.xml (it should
probably be moved to a more central place):

      <column name="db_version">
        <p>
          The database schema version number in the form
          <code><var>major</var>.<var>minor</var>.<var>tweak</var></code>,
          e.g. <code>1.2.3</code>.  Whenever the database schema is changed in
          a non-backward compatible way (e.g. deleting a column or a table),
          <var>major</var> is incremented.  When the database schema is changed
          in a backward compatible way (e.g. adding a new column),
          <var>minor</var> is incremented.  When the database schema is changed
          cosmetically (e.g. reindenting its syntax), <var>tweak</var> is
          incremented.
        </p>

        <p>
          The schema version is part of the database schema, so it can also be
          retrieved by fetching the schema using the Open vSwitch database
          protocol.
        </p>
      </column>

If you're OK with that let me know and I'll apply this with that
changed.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to