On Wed, May 11, 2016 at 12:44 AM, Markos Chandras <mchand...@suse.de> wrote:
> On 05/11/2016 02:41 AM, Jesse Gross wrote:
>> On Tue, May 10, 2016 at 1:21 AM, Markos Chandras <mchand...@suse.de> wrote:
>>> Commit e2f3178f0582 ("datapath: Add support for kernel 3.14.") added
>>> support for 3.14 kernels and a new OVS_GREP_IFELSE check for the
>>> "skg_get_hash" function in the process. "skb_get_hash" was introduced
>>> in the Linux kernel commit 3958afa1b272 ("net: Change skb_get_rxhash to
>>> skb_get_hash") which exists in >=3.14 but the OVS_GREP_IFELSE macro
>>> also matches the "skb_get_hash_raw" function which exists in older
>>> kernels. As a result of which, the check makes the build system
>>> behave as if the "skb_get_hash" function is available in these older
>>> kernels leading to build failures. We fix this by explicitly checking
>>> for "skb_get_hash(" which matches the function definition.
>>>
>>> Signed-off-by: Markos Chandras <mchand...@suse.de>
>>
>> It looks like skb_get_hash_raw() was introduced upstream in 3.14 as
>> well. Are there distribution kernels that you are referring to that
>> have backported one but not the other?
>>
> Hi Jesse,
>
> You are right. SUSE has backported that commit to the SLE12 kernel which
> is 3.12.OK, I've applied this to master, branch-2.5, and branch-2.3. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
