On Tue, May 10, 2016 at 10:31 AM, Pravin B Shelar <pshe...@ovn.org> wrote:
> diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c
> index a716492..62ee945 100644
> --- a/lib/netdev-native-tnl.c
> +++ b/lib/netdev-native-tnl.c
> @@ -227,20 +227,32 @@ netdev_tnl_push_udp_header(struct dp_packet *packet,
[...]
> + if (packet->lso.type) {
> + udp_csum = ~csum_finish(csum);
Is it possible that the pseudoheader is zero? If so, this would cause
us to not compute the full checksum later on.
As a general comment on this series, have you done any performance
testing (particularly around STT)? There are a lot of complex and
expensive looking operations as part of both reassembly and
segmentation and so I wonder whether the performance will be at a
level that this is really viable.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
