Hi Nithin, Geneve and VXLAN have same UDP headers. If we are using same port as both tunnel endpoints, I don't see a clear way to distinguish between the two on the RX path. Besides, this function is currently a strictly inferior version of OvsFindTunnelVportByPortType, which takes one fewer parameter but also returns a single port. Does that mean this function should be removed?
Best regards, Yin Lin ________________________________________ From: Nithin Raju Sent: Thursday, May 19, 2016 5:05 PM To: Yin Lin; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 3/3] [PATCH v3] Add Geneve support in Windows datapath -----Original Message----- From: dev <dev-boun...@openvswitch.org> on behalf of Yin Lin <li...@vmware.com> Date: Thursday, May 19, 2016 at 2:49 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Cc: Yin Lin <li...@vmware.com> Subject: [ovs-dev] [PATCH 3/3] [PATCH v3] Add Geneve support in Windows datapath >OvsFindTunnelVportByDstPort(POVS_SWITCH_CONTEXT switchContext, >- UINT16 dstPort, >- OVS_VPORT_TYPE ovsPortType) >+ UINT16 dstPort) What is the rationale for this change? The reason we are also passing ŒovsPortType¹ is that you can have a VXLAN and an STT tunnel for instance on the same L4 port number. So, we need to distinguish between the two. -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
