Tested-by: Ramu Ramamurthy <[email protected]>
I tested this patchset to work end-to-end with openstack (with the
corresponding WIP openstack patch).
> + /* Check that the DHCP Message Type (opt 53) is present or not with
> + * valid values - DHCP_MSG_DISCOVER or DHCP_MSG_REQUEST as the first
> + * DHCP option.
> + */
> + if (!(in_dhcp_opt[0] == DHCP_OPT_MSG_TYPE && in_dhcp_opt[1] == 1 && (
> + in_dhcp_opt[2] == DHCP_MSG_DISCOVER ||
> + in_dhcp_opt[2] == DHCP_MSG_REQUEST))) {
> + /* Invalid dhcp packet. Resume the packet without further
> + * processing. */
> + goto exit;
> + }
> +
Would it make sense to log messages are not handling (nak, decline,
release, inform)
to help debug (rare) scenarios when VMs dont get dhcp IPs as expected.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
