On Mon, May 23, 2016 at 09:07:25PM +0000, Daniele Di Proietto wrote: > On 23/05/2016 14:00, "Ben Pfaff" <[email protected]> wrote: > > >On Mon, May 23, 2016 at 01:43:47PM -0700, Daniele Di Proietto wrote: > >> Without the last OVSDB_SERVER_SHUTDOWN, the test hangs on travis, > >> because ovsdb-server is still running. > >> > >> Tested-at: https://travis-ci.org/ddiproietto/ovs/builds/132343426 > >> Signed-off-by: Daniele Di Proietto <[email protected]> > > > >That's a sign that we should, additionally, have > > on_exit 'kill `cat *.pid`' > >or similar embedded in the test. Otherwise if some part of the test > >before OVSDB_SERVER_SHUTDOWN fails, nothing will kill the database > >server and the test will hang anyway. > > > >(It looks like other tests in ovsdb-idl.at have that problem too.) > > It looks like every AT_CHECK in those tests kills the server in case of > failure.
I must have written these tests before on_exit was available. > I agree that it would be much better to use on_exit. I can change > that as part of this fix, if you agree. Please! Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
