On 02/06/2016 13:16, "Ben Pfaff" <b...@ovn.org> wrote:
>On Wed, Jun 01, 2016 at 07:22:48PM -0700, Daniele Di Proietto wrote:
>> In the run() function of ofproto-dpif we call rule_expire() for every
>> possible flow that has a timeout and rule_expire() calls time_msec().
>> Calling time_msec() repeatedly can be pretty expensive, even though most
>> of the time it involves only a vdso call.
>>
>> This commit calls time_msec only once in run(), to reduce the workload.
>>
>> Keeping the flows ordered by expiration in some kind of heap or timing
>> wheel data structure could help make this process more efficient, if
>> rule_expire() turns out to be a bottleneck.
>>
>> VMware-BZ: #1655122
>> Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com>
>
>Acked-by: Ben Pfaff <b...@ovn.org>
Thanks for the quick review, I applied this to master
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
