On Fri, Jun 03, 2016 at 05:07:39PM +0200, Jan Scheurich wrote: > Thanks for the review. Will update. > > > In some places, this is called "add_or_modify" and in other places just > > "write". I suggest using a consistent name. > > Which one would you suggest?
I don't like the idea of using "write", because "write-actions" has a specific meaning in OpenFlow and users might falsely associate it with "write-groups". On the other hand, "add_or_modify" is a bit long and awkward. Here is what I suggest. In code, use "add_or_modify", because it is clear. In the ovs-ofctl command-line interface, do not add a new command; instead, add a new option --may-create to the mod-group command which uses add_or_modify. This has precedent in the ovs-dpctl command, which has a --may-create option on its mod-flow command. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
