Thanks for the review.
From: Yin Lin <yinli...@gmail.com<mailto:yinli...@gmail.com>>
Date: Thursday, June 2, 2016 at 3:00 PM
To: Nithin Raju <nit...@vmware.com<mailto:nit...@vmware.com>>
Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>"
<dev@openvswitch.org<mailto:dev@openvswitch.org>>
Subject: Re: [ovs-dev] [PATCH] datapath-windows: use ip proto for tunnel port
lookup
Thanks Nithin for working on this! The fix overall looks pretty good.
Can we get rid of OvsFindTunnelVportByPortType since it doesn't make much sense
and is dangerous to call if user doesn't understand what it actually does?
Done in the v2.
Also, there is some misalignment in the following code. Did you use tab?
- if (tunnelVport) {
+ tunnelVport =
+ OvsFindTunnelVportByDstPortAndNWProto(ovsFwdCtx->switchContext,
+ dstPort,
+ flowKey->ipKey.nwProto);
+ if (tunnelVport) {
+ switch(tunnelVport->ovsType) {
+ case OVS_VPORT_TYPE_STT:
ovsActionStats.rxStt++;
- }
Alignment looks correct. I have checked it after applying the patch.
-- Nithin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
