This test wasn't aimed specifically to test what happens if the log file isn't closed before it's overwritten, so it seemed reasonable to me to just close it everywhere.
I prefer to have only a single code path where we can. On Mon, Jun 06, 2016 at 07:09:58PM +0000, Alin Serdean wrote: > From windows point of view, it looks good, because we need to close > file (handle) before we try to move it. > > In my opinion we should not change anything on the Linux side, so > either ifdef it or create a new macro for this particular case > (closing a log file) which can be used later on. > > Maybe the rest have a different opinion on this subject. > > > On Windows trying to overwrite the opened ovs-vswitchd.log fails with > > access denied. Closing it before trying to overwrite it solves the problem > > > > Signed-off-by: Paul-Daniel Boca <pb...@cloudbasesolutions.com> > > --- > > V2: Use same command both for Windows and Linux. > > Previous version had '.exe' extension at ovs-appctl. > > --- > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
