On Thu, Jun 9, 2016 at 4:42 AM, Flavio Leitner <f...@sysclose.org> wrote:
> On Tue, Jun 07, 2016 at 11:42:11PM +0200, Mauricio Vásquez wrote: > > On Tue, Jun 7, 2016 at 10:52 PM, Bodireddy, Bhanuprakash < > > bhanuprakash.bodire...@intel.com> wrote: > > > > > Thanks Mauricio for your comments, My comments inline. > > > > > > >+ it has to be configured with DPDK support and is done by > './configure > > > -- > > > >with-dpdk'. > > > >+ This section focus on generic recipe that suits most cases and for > > > >distribution > > > >+ specific instructions, refer [INSTALL.Fedora.md], [INSTALL.RHEL.md > ] > > > and > > > >+ [INSTALL.Debian.md]. > > > > > > > >-9. Rx Mergeable buffers > > > >+ OVS can be downloaded in compressed format from the OVS release > page > > > >(or) > > > >+ cloned from git repository if user intends to develop and > contribute > > > >+ patches upstream. > > > > > > > > I think it is better just to have one download method, it keeps > things > > > simple. > > > > > > [BHANU] This is done for a reason. Most of the users would like to > work > > > on a stable release and few would be working on the master branch. > > > > > > > The point here is that this file is in the master branch, if a user wants > > to use a stable release it should download that stable release and read > the > > installation guide for that specific release. > > > > > > > One section covers downloading the stable release as compressed file. > This > > > section would be updated once 2.6 is released. > > > Other section comes handy for users working on master. > > > > > > > I see that both methods are actually downloading the master version. > > > > Additionally, I think that keeping instructions in the master about how > to > > compile previous versions can be difficult, mainly due to the DPDK > required > > version. As an example, if you want to include here instructions for ovs > > 2.5 you have to use DPDK 2.2. > > I sort of disagree here for two reasons. One is that I think we > should assume the user is reading the document from the sources, > so no downloading instructions are needed. I think that is the > approach used by INSTALL.md and it seems to be working. > > The second reason is that the sources in the development branch > is going to be in the release tarball at some point. Let's say > next 2.6 will point only to master snapshots. So, it seems to > me that if we want to keep the downloading instructions, we could > get both ways explained. For example: > > The OVS sources can be downloaded in different ways and you can skip > this section if you already have the correct sources. Otherwise > download the correct version using one of the suggested methods below > and follow the documentation provided for that specific version. > > * OVS stable releases can be downloaded in compressed format from > http://openvswitch.org/releases/ > > wget -O ovs.tar http://openvswitch.org/releases/openvswitch- > <version>.tar.gz > mkdir -p /usr/src/ovs > tar -xvf ovs.tar -C /usr/src/ovs --strip-components=1 > export OVS_DIR=/usr/src/ovs > > * OVS current development can be downloaded in compressed format from > https://github.com/openvswitch/ovs/tarball/master > wget -O ovs.tar https://github.com/openvswitch/ovs/tarball/master > mkdir -p /usr/src/ovs > tar -xvf ovs.tar -C /usr/src/ovs --strip-components=1 > export OVS_DIR=/usr/src/ovs > > * OVS current development can be clone using 'git' tool: > cd /usr/src/ > git clone https://github.com/openvswitch/ovs.git > export OVS_DIR=/usr/src/ovs > > fbl > > I agree with that approach, the point is to tell the user to read the proper documentation. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
