"dev" <[email protected]> wrote on 06/15/2016 02:21:48 PM:
> From: Ryan Moats/Omaha/IBM@IBMUS > To: Nirapada Ghosh/San Jose/IBM@IBMUS > Cc: [email protected] > Date: 06/15/2016 02:22 PM > Subject: Re: [ovs-dev] [PATCH V9] ovn-controller: reload configured > SB probetimer > Sent by: "dev" <[email protected]> > > "dev" <[email protected]> wrote on 06/15/2016 11:29:18 AM: > > > From: Nirapada Ghosh/San Jose/IBM@IBMUS > > To: [email protected] > > Date: 06/15/2016 11:29 AM > > Subject: [ovs-dev] [PATCH V9] ovn-controller: reload configured SB probe > timer > > Sent by: "dev" <[email protected]> > > > > From: Nirapada Ghosh <[email protected]> > > > > The probe timer between ovn-controller and OVN Southbound > > can be configured using ovn-vsctl command, but that is not > > effective on the fly. In other words, ovn-controller has > > to be restarted to use that probe_timer value, this patch > > takes care of that. > > > > This change has been tested putting logs in several places like in > > ovn-controller.c, lib/rconn.c to make sure the right probe_timer > > values are in effect. > > Signed-off-by: Nirapada Ghosh <[email protected]> > > > > --- > > This needs more work, both in terms of the dependency on pkg-config > (which IIRC is OS specific) and the potential infinite recursion > loop when the feature is turned on... Please disregard the above - I replied to the wrong patch with it (my bad). However, my review makes me question the following code snippet: @@ -418,6 +392,13 @@ main(int argc, char *argv[]) .ovnsb_idl_txn = ovsdb_idl_loop_run(&ovnsb_idl_loop), }; + if (!cfg) { + ovsrec_open_vswitch_first(ovs_idl_loop.idl); Shouldn't the above be cfg = ovsrec_open_vswitch_first(ovs_idl_loop.idl) ? + } + if (cfg) { + update_probe_interval(cfg, ovnsb_idl_loop.idl); + } + Ryan Moats _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
