Responding to icmp queries where the L3 destination is a directed broadcast was not being properly handled, causing the reply to be sent to all logical ports except for the one port that should receive it.
This is a proposal for using choice B in the mail discussion; where icmp queries to broadcast are simply not responded by the logical router. Reported-at: http://openvswitch.org/pipermail/discuss/2016-June/021619.html Signed-off-by: Flavio Fernandes <[email protected]> --- Changes v1->v2: - Rebase - Use Reported-at label for proper referencing ovn/northd/ovn-northd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index d53fca9..752e032 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -1957,9 +1957,8 @@ build_lrouter_flows(struct hmap *datapaths, struct hmap *ports, * (i.e. the incoming locally attached net) does not matter. * The ip.ttl also does not matter (RFC1812 section 4.2.2.9) */ match = xasprintf( - "(ip4.dst == "IP_FMT" || ip4.dst == "IP_FMT") && " - "icmp4.type == 8 && icmp4.code == 0", - IP_ARGS(op->ip), IP_ARGS(op->bcast)); + "ip4.dst == "IP_FMT" && icmp4.type == 8 && icmp4.code == 0", + IP_ARGS(op->ip)); char *actions = xasprintf( "ip4.dst = ip4.src; " "ip4.src = "IP_FMT"; " -- 1.9.1 _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
