"Li, Johnson" <johnson...@intel.com> wrote on 06/15/2016 10:06:10 PM:
> From: "Li, Johnson" <johnson...@intel.com>
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: "dev@openvswitch.org" <dev@openvswitch.org>
> Date: 06/15/2016 10:06 PM
> Subject: RE: [RFC PATCH 01/14] Add VxLAN-GPE extension for the
Openvswitch
>
> >"dev" <dev-boun...@openvswitch.org> wrote on 06/16/2016 04:51:34 AM:
>
> > > + return -EMSGSIZE;
> > > +
> > > + nla_nest_end(skb, exts);
> >
> > Nit: since this is almost identical to the previous block, I think
> > a refactoring where this block is abstracted into a helper or a
> > macro might make for easier reading.
> >
> Thanks, I will try to do that.
>
> > > VLOG_WARN("%s: unknown extension '%s'", name,
ext);
> > > }
> > > --
> > > 1.8.4.2
> >
> > I know this is an RFC patch, but shouldn't the patch include
> > some additional test code for this extension?
> >
> > Ryan
> We had some test cases while developing. Test cases will be added in the
> next version of patch set.
Great - I look forward to seeing them!
Ryan
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
