Thadeu Lima de Souza Cascardo <casca...@redhat.com> writes:

> "received bad netlink message" may be interpreted as a corrupt netlink 
> message.
> However, the parse functions may return failure when the message contains
> unexpected attributes or misses non optional attributes. Indicating the 
> message
> contained "unexpected contents" will avoid some interpretation that there may 
> be
> some netlink message corruption.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com>
> Cc: Aaron Conole <acon...@redhat.com>
> ---
>  lib/netlink-notifier.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/netlink-notifier.c b/lib/netlink-notifier.c
> index f6d1e4d..0867952 100644
> --- a/lib/netlink-notifier.c
> +++ b/lib/netlink-notifier.c
> @@ -194,7 +194,7 @@ nln_run(struct nln *nln)
>              if (group != 0) {
>                  nln_report(nln, nln->change, group);
>              } else {
> -                VLOG_WARN_RL(&rl, "received bad netlink message");
> +                VLOG_WARN_RL(&rl, "unexpected netlink message contents");
>                  nln_report(nln, NULL, 0);
>              }
>              ofpbuf_uninit(&buf);

LGTM
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to