Ben Pfaff <[email protected]> wrote on 06/23/2016 04:40:01 PM:

> From: Ben Pfaff <[email protected]>
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: [email protected]
> Date: 06/23/2016 04:40 PM
> Subject: Re: [ovs-dev,v18,5/9] Refactor lflow.c
>
> On Wed, Jun 08, 2016 at 08:02:58PM -0500, Ryan Moats wrote:
> > From: "RYAN D. MOATS" <[email protected]>
> >
> > Refactor code block inside of SBREC_LOGICAL_FLOW_FOR_EACH
> > loop in add_logical_flow so that this can be reused when
> > incremental processing is added.
> >
> > Signed-off-by: RYAN D. MOATS <[email protected]>
>
> Patches 5-8 seem OK to me at first glance; they're mostly moving code
> around.
>
> I'll wait for a revision of patch 4 before looking at them in detail.

That's up to you, they are pretty much independent of patch 4, but
I can re-roll them as well.

> I haven't really started reviewing patch 9 yet.

That's the tricky one - it *is* dependent on patches 4-8, so it has
to wait for a respin.

I'm sending replies on patch 4 under separate cover.

Ryan
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to