On Thu, Jun 09, 2016 at 10:09:33PM +0530, Numan Siddique wrote: > On Thu, Jun 9, 2016 at 11:07 AM, Ben Pfaff <b...@ovn.org> wrote: > > > Patches 1 and 2 are new. > > > > Patch 3 is based on https://patchwork.ozlabs.org/patch/631320/, with: > > - Minor style fixes. > > - Change syntax of put_dhcp_opts(), from: > > put_dhcp_opts(reg0, offerip=1.2.3.4, ...) > > to: > > reg0[0] = put_dhcp_opts(offerip=1.2.3.4, ...) > > That is, the result is now expressed as a return value, which is > > more natural for people coming from C, and the result is now a > > single bit instead of an entire register, which makes more sense > > for a Boolean anyway and doesn't use up a whole register. > > - Arguments to put_dhcp_opts are now architecture independent instead > > of host-endian, which makes it possible to test them using the > > test-ovn "parse-actions" instead of a separate program. > > - Added negative tests for put_dhcp_opts parsing. > > Ben, I dont see these test cases in the patch 3 of this series. Is it TODO > or you have missed out some how.
Those are the tests that provoke failures in ovn.at, these ones: +reg1[0..1] = put_dhcp_opts(offerip = 1.2.3.4, router = 10.0.0.1); => Cannot use 2-bit field reg1[0..1] where 1-bit field is required. +reg1[0] = put_dhcp_opts(); => Syntax error at `)'. +reg1[0] = put_dhcp_opts(x = 1.2.3.4, router = 10.0.0.1); => Syntax error at `x' expecting offerip option. +reg1[0] = put_dhcp_opts(offerip=1.2.3.4, "hi"); => Syntax error at `"hi"'. +reg1[0] = put_dhcp_opts(offerip=1.2.3.4, xyzzy); => Syntax error at `xyzzy' expecting DHCP option name. +reg1[0] = put_dhcp_opts(offerip="xyzzy"); => DHCP option offerip requires numeric value. +reg1[0] = put_dhcp_opts(offerip=1.2.3.4, domain=1.2.3.4); => DHCP option domain requires string value. > > - Revised documentation to avoid talking about "pausing" and "resuming" > > the pipeline. The trip to ovn-controller should be transparent to > > the writer of the OVN logical flows. > > > > Patch 4 is based on https://patchwork.ozlabs.org/patch/631321/, with: > > - Minor style fixes. > > - Adapt actions to changed put_dhcp_opts() syntax. > > > > Same here. I dont see this in the patch 4 of this series. Hmm, did I miss those? Sorry then. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
