Hi Ben,

It’s because of the "packet send error" statistic. The test of checking IPFIX 
statistics set collector as “127.0.0.1:4739”.
Test code:
-----------------------------------------------------
dnl Sample every packet using bridge-based sampling.
AT_CHECK([ovs-vsctl -- set bridge br0 ipfix=@fix -- \
                    --id=@fix create ipfix targets=\"127.0.0.1:4739\" \
                              sampling=1], [0], [ignore])
——————————————————————————

We expect “ tx errs=12” because we don’t listen on port 4739 on local host.
Test code:
-----------------------------------------------------
AT_CHECK([ovs-ofctl dump-ipfix-bridge br0], [0], [dnl
NXST_IPFIX_BRIDGE reply (xid=0x2):
  bridge ipfix: flows=20, current flows=0, sampled pkts=20, ipv4 ok=0, ipv6 
ok=0, tx pkts=12
                pkts errs=20, ipv4 errs=20, ipv6 errs=0, tx errs=12
])
——————————————————————————

As I talked with Wenyu, she has listened on port 4739 for testing. If port 4739 
on the local host is listened, there will
be no "tx errs”.

Should we remove "tx errs” check?

Bests,
Daniel

> On Jun 25, 2016, at 11:57 AM, Ben Pfaff <b...@ovn.org> wrote:
> 
> The tests under "make check" try to be environment independent.  Do you
> know what factor of your environment caused the failures?  Perhaps we
> can fix it.
> 
> On Sat, Jun 25, 2016 at 01:11:04AM +0000, Wenyu Zhang wrote:
>> It is caused by an environment issue.
>> Clear the environment and rerun the tests, all
>> tests passed now.
>> 
>> ???? iPhone
>> 
>> ? 2016?6?25????8:35?Wenyu Zhang 
>> <wen...@vmware.com<mailto:wen...@vmware.com>> ???
>> 
>> All tests passed except following two cases?
>> 1055: ofproto-dpif - Bridge IPFIX statistics check    FAILED 
>> (ofproto-dpif.at<https://urldefense.proofpoint.com/v2/url?u=http-3A__ofproto-2Ddpif.at_&d=CwIBAg&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=AMeQBzObb3Yn4XemNxgato0M1gEhd6eNH0myARLK2io&m=3tT8zWJ-n2PG-Vl1hJ7bqR6TzF0Y6kvUMsCiVFteruc&s=sYJQ7uB_IEN0lN6g1_BnSAIPN69JN8wurN_OlTAbVCY&e=
>>  >:5975)
>> 1058: ofproto-dpif - Flow IPFIX statistics check      FAILED 
>> (ofproto-dpif.at<https://urldefense.proofpoint.com/v2/url?u=http-3A__ofproto-2Ddpif.at_&d=CwIBAg&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=AMeQBzObb3Yn4XemNxgato0M1gEhd6eNH0myARLK2io&m=3tT8zWJ-n2PG-Vl1hJ7bqR6TzF0Y6kvUMsCiVFteruc&s=sYJQ7uB_IEN0lN6g1_BnSAIPN69JN8wurN_OlTAbVCY&e=
>>  >:6140)
>> 
>> The errors exist without this patch. We are looking at the errors and try to 
>> fix it later.
>> 
>> 
>> ? 2016?6?25????8:11?Wenyu Zhang 
>> <wen...@vmware.com<mailto:wen...@vmware.com>> ???
>> 
>> In virtual network, users want more info about the virtual point to observe 
>> the traffic.
>> It should be a string to provide clear info, not a simple interger ID.
>> 
>> Introduce "other-config: virtual_obs_id" in IPFIX, which is a string 
>> configured by user.
>> Introduce an enterprise IPFIX entity "virtualObsID"(898) to export the 
>> value. The entity is a
>> variable-length string.
>> 
>> Signed-off-by: Wenyu Zhang <wen...@vmware.com<mailto:wen...@vmware.com>>
>> ---
>> NEWS                                  |  11 ++--
>> ofproto/ipfix-enterprise-entities.def |   1 +
>> ofproto/ofproto-dpif-ipfix.c          | 102 
>> ++++++++++++++++++++++++++++++----
>> ofproto/ofproto.h                     |   2 +
>> vswitchd/bridge.c                     |  13 +++++
>> vswitchd/vswitch.xml                  |  33 +++++++++++
>> 6 files changed, 147 insertions(+), 15 deletions(-)

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to