Just one suggestion, but looks good otherwise. Acked-by: Nithin Raju <nit...@vmware.com>
-----Original Message----- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Friday, June 24, 2016 at 12:03 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [ovs-dev] [PATCH v3 5/9] Windows: Add conntrack-flush support in userspace >Modify dpif-netlink.c and netlink-conntrack.c to send down flush command >to Windows datapath. Include netlink-conntrack.c and netlink-conntrack.h >in automake.mk for Windows binaries. > >Windows currently supports only NETLINK_GENERIC port. In order to support >the NETLINK_NETFILTER messages, the port id is being overwritten to >NETLINK_GENERIC on Windows and datapath has been updated to support the >new message format. > >Signed-off-by: Sairam Venugopal <vsai...@vmware.com> >Acked-by: Paul-Daniel Boca <pb...@cloudbasesolutions.com> >diff --git a/lib/netlink-conntrack.c b/lib/netlink-conntrack.c >index 47a3c62..799887d 100644 >--- a/lib/netlink-conntrack.c >+++ b/lib/netlink-conntrack.c >@@ -75,6 +75,13 @@ static struct vlog_rate_limit rl = >VLOG_RATE_LIMIT_INIT(1, 5); > #define IPS_UNTRACKED_BIT 12 > #define IPS_UNTRACKED (1 << IPS_UNTRACKED_BIT) > >+#ifdef _WIN32 >+#ifdef NETLINK_NETFILTER >+#undef NETLINK_NETFILTER >+#endif >+#define NETLINK_NETFILTER NETLINK_GENERIC /* Override for Windows >*/ >+#endif Might be helpful to document the reason also since it is a design decision. Basically, we use the same sockets for nfgenmsg and genlmsghdr messages. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
