On Fri, Jul 01, 2016 at 04:27:49PM +0000, Paul Boca wrote: > If the PID file isn't locked then appctl.py detects it as stale and > bails out without doing anything. Because of this lots of Python tests fail. > Also this protects the PID file from being overwritten. > > I used only shared lock, in order to be compatible with Python tests, > which try to acquire the lock exclusively. On Windows if the exclusive lock > is used, than the read access is denied too for other instances of this file. > > Signed-off-by: Paul-Daniel Boca <pb...@cloudbasesolutions.com>
I'm still not sure that real locking is actually needed for Windows. I believe that, on Windows, the functionality of a lock file only requires holding the file open. For a program to detect whether the lock file is locked, it can just try to delete it; on Windows, I believe that deleting an open file fails. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
