On Fri, Jul 1, 2016 at 5:58 PM, Pravin B Shelar <pshe...@ovn.org> wrote:
> diff --git a/datapath/linux/compat/geneve.c b/datapath/linux/compat/geneve.c
> index 0399de7..b6c091c 100644
> --- a/datapath/linux/compat/geneve.c
> +++ b/datapath/linux/compat/geneve.c
> @@ -669,7 +667,6 @@ netdev_tx_t rpl_geneve_xmit(struct sk_buff *skb)
> rt = geneve_get_rt(skb, dev, &fl4, info);
> if (IS_ERR(rt)) {
> netdev_dbg(dev, "no route to %pI4\n", &fl4.daddr);
> - dev->stats.tx_carrier_errors++;
> goto tx_error;
Does this need err = PTR_ERR(rt)?
> diff --git a/datapath/linux/compat/lisp.c b/datapath/linux/compat/lisp.c
> index f1f50ae..20959ac 100644
> --- a/datapath/linux/compat/lisp.c
> +++ b/datapath/linux/compat/lisp.c
> +int ovs_lisp_fill_metadata_dst(struct net_device *dev, struct sk_buff *skb)
> +{
> + struct lisp_dev *lisp = netdev_priv(dev);
> + struct net *net = lisp->net;
> + struct ip_tunnel_info *info = skb_tunnel_info(skb);
> + __be16 sport, dport;
> +
> + sport = htons(get_src_port(net, skb));
> + dport = info->key.tp_dst ? : lisp->dst_port;
I think in the LISP transmit code, the dest port is always
list->dst_port and it doesn't take the port from ip_tunnel_info.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
