Hi Alin! I think that the same fix can be applied to " daemon --detach --monitor startup errors"
Acked-by: Paul Boca <[email protected]> > -----Original Message----- > From: dev [mailto:[email protected]] On Behalf Of Alin Serdean > Sent: Tuesday, July 12, 2016 6:36 PM > To: [email protected] > Subject: [ovs-dev] [PATCH] tests: daemon specific tests > > Testing out the named pipe implementation revealed a problem in > "daemon --detach startup errors". If the daemon actually started nobody > is stopping it. > In the case of test failure kill the daemon. > > Signed-off-by: Alin Gabriel Serdean <[email protected]> > --- > tests/daemon.at | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/daemon.at b/tests/daemon.at > index 8f88987..cf95cde 100644 > --- a/tests/daemon.at > +++ b/tests/daemon.at > @@ -153,7 +153,8 @@ AT_CLEANUP > AT_SETUP([daemon --detach startup errors]) > AT_CAPTURE_FILE([pid]) > OVSDB_INIT([db]) > -AT_CHECK([ovsdb-server --detach --no-chdir --pidfile="`pwd`"/pid -- > unixctl="`pwd`"/nonexistent/unixctl db], [1], [], [stderr]) > +AT_CHECK([ovsdb-server --detach --no-chdir --pidfile="`pwd`"/pid -- > unixctl="`pwd`"/nonexistent/unixctl db], [1], [], [stderr], > + [kill `cat pid`]) > AT_CHECK([grep 'ovsdb-server: could not initialize control socket' stderr], > [0], [ignore], []) > AT_CHECK([test ! -s pid]) > -- > 1.9.5.msysgit.0 > _______________________________________________ > dev mailing list > [email protected] > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
