On Mon, Jul 18, 2016 at 11:40 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Jul 15, 2016 at 08:33:59PM +0530, Numan Siddique wrote: > > To support 128-bits in ct_label, the value of the ct_label is expected > > as a hex string in the 'ct_commit' action. > > > > Added a new accessor in the 'mf_subvalue' struct to access ovs_be128 > > values. > > > > Signed-Off-by: Numan Siddique <nusid...@redhat.com> > > Only the "s" should be capitalized in "Signed-off-by". I know that's > petty but Git only properly recognizes it with the right capitalization. >
I was doing the same mistake all this time. Thanks for pointing it out. I will take care of it from next time. > > @@ -982,9 +982,8 @@ > > <code>ct_mark</code> and/or <code>ct_label</code> will be > set to the > > values indicated by <var>value[/mask]</var> on the > connection > > tracking entry. <code>ct_mark</code> is a 32-bit field. > > - <code>ct_label</code> is technically a 128-bit field, > though OVN > > - currently only supports 64-bits and will later be extended > to > > - support the full 128-bits. > > + <code>ct_label</code> is a 128-bit field. The > <var>value[/mask]</var> > > + should be specified in hex string if > 64-bits are to be > used. > > It seems asking for trouble to put a literal > into XML, so I rephrased > this to avoid it. > > > </p> > > With that change, I applied this to master. Thank you! > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
