> On Jul 18, 2016, at 7:37 AM, Ryan Moats <rmo...@us.ibm.com> wrote: > > "dev" <dev-boun...@openvswitch.org> wrote on 07/02/2016 12:25:11 PM: > > > From: Ben Pfaff <b...@ovn.org> > > To: Justin Pettit <jpet...@ovn.org> > > Cc: dev@openvswitch.org, Hui Kang <hkang.sun...@gmail.com> > > Date: 07/02/2016 12:25 PM > > Subject: Re: [ovs-dev] [PATCH] [OVN-northd] Rename nbs/nbr to nbsp/nbrp > > Sent by: "dev" <dev-boun...@openvswitch.org> > > > > On Fri, Jun 24, 2016 at 12:39:54PM -0400, Hui Kang wrote: > > > These variables indicate ports in nb switches or routers. > > > > > > Signed-off-by: Hui Kang <ka...@us.ibm.com> > > > > Justin, do you want to review this? You like naming. > > I'll throw my $0.02 onto the table (and yes, it's only barely > worth $0.02) - if we are going to rename them, how about we > change them to nlsp and nlrp so that they align with the > structs that they are holding pointers to.
I could go either way on that. However, if the ports are renamed in that way, the switches and routers should be similarly renamed to "nls" and "nlr" to keep it consistent. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
