-----"dev" <[email protected]> wrote: -----
>To: [email protected]
>From: Chandra Sekhar Vejendla/San Jose/IBM@IBMUS
>Sent by: "dev"
>Date: 07/18/2016 05:50AM
>Subject: [ovs-dev] [PATCH] ovn: Add datapth of gateway port to local_datapaths
>
>When a l3 gateway port is created on a chassis, the corresponding
>datapath is not added to local datapths. This results in patch
>ports not getting created between local network and br-int
>
>Signed-off-by: Chandra Sekhar Vejendla <[email protected]>
>---
> ovn/controller/binding.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c
>index 4704226..1d5bd32 100644
>--- a/ovn/controller/binding.c
>+++ b/ovn/controller/binding.c
>@@ -253,6 +253,14 @@ consider_local_datapath(struct controller_ctx *ctx,
>struct shash *lports,
> binding_rec->logical_port);
> sbrec_port_binding_set_chassis(binding_rec, NULL);
> }
>+ } else if (!strcmp(binding_rec->type, "gateway")) {
>+ const char *chassis = smap_get(&binding_rec->options,
>+ "gateway-chassis");
>+ if (!strcmp(chassis, chassis_rec->name) && ctx->ovnsb_idl_txn) {
>+ sset_add(&all_lports, binding_rec->logical_port);
>+ add_local_datapath(local_datapaths, binding_rec,
>+ &binding_rec->header_.uuid);
As long as you are adding some "gateway" processing to binding.c, I am
wondering if sbrec_port_binding_set_chassis processing should be moved from
patch.c to binding.c. That would consolidate all the
sbrec_port_binding_set_chassis processing in binding.c, and align the L3
gateway code with the L2 gateway code. More of a nice to have than something
that is necessary.
Mickey
>+ }
> } else if (!binding_rec->chassis
> && !strcmp(binding_rec->type, "localnet")) {
> /* Localnet ports will never be bound to a chassis, but we want
>--
>2.6.1
>
>_______________________________________________
>dev mailing list
>[email protected]
>http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
