Liran Schour/Haifa/IBM wrote on 07/25/2016 02:44:42 AM: > From: Liran Schour/Haifa/IBM > To: Ryan Moats <rmo...@us.ibm.com> > Cc: dev@openvswitch.org > Date: 07/25/2016 02:44 AM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Handle physical > changes correctly > > > From: Ryan Moats <rmo...@us.ibm.com> > > To: dev@openvswitch.org > > Date: 23/07/2016 12:57 AM > > Subject: [ovs-dev] [PATCH] ovn-controller: Handle physical changescorrectly > > Sent by: "dev" <dev-boun...@openvswitch.org> > > > > [1] reported increased failure rates in certain tests > > with incremental processing (the numbers are the number of failures > > seen in 100 tests): > > > > 2 ovn -- vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS > > 10 ovn -- 2 HVs, 2 LS, 1 lport/LS, 2 peer LRs > > 52 ovn -- 1 HV, 1 LS, 2 lport/LS, 1 LR > > 45 ovn -- 1 HV, 2 LSs, 1 lport/LS, 1 LR > > 23 ovn -- 2 HVs, 3 LS, 1 lport/LS, 2 peer LRs, static routes > > 53 ovn -- 2 HVs, 3 LRs connected via LS, static routes > > 32 ovn -- 2 HVs, 2 LRs connected via LS, gateway router > > 50 ovn -- icmp_reply: 1 HVs, 2 LSs, 1 lport/LS, 1 LR > > > > These failures were caused by a combination of problems in > > handling physical changes: > > > > 1. When a vif was removed, the localvif_to_ofport entry was not > > removed. > > 2. When a physical change was detected, ovn-controller would wait > > a poll cycle before processing the logical flow table. > > > > This patch set addresses both of these issues while simultaneously > > cleaning up the code in physical.c. A side effect is a modification > > of where OF flows are dumped in the gateway router case that allowed > > the root causes of this issue to be found. > > > > With these changes, all of the above tests had a 100/100 success rate. > > > > [1] http://openvswitch.org/pipermail/dev/2016-July/075803.html > > > > Signed-off-by: Ryan Moats <rmo...@us.ibm.com> > > --- > > This patch really improves the tests however on my performance > evaluation environment it results in a 100% CPU load on the ovn-controllers.
I'm pretty sure I know what's causing that - let's see if I can revert that without impacting test results... _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
