On Thu, Jul 28, 2016 at 02:11:52PM -0500, Ryan Moats wrote: > Ben Pfaff <b...@ovn.org> wrote on 07/28/2016 01:39:53 PM: > > > From: Ben Pfaff <b...@ovn.org> > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 07/28/2016 01:40 PM > > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Clean up cases that > > lead to duplicate OF flows. > > > > On Thu, Jul 28, 2016 at 06:10:16PM +0000, Ryan Moats wrote: > > > In physical_run, there are multiple places where OF flows can be > > > produced each cycle. Because the desired flow table may not have > > > been completely cleared first, remove flows created during previous > > > runs before creating new flows. This avoid collisions. > > > > > > Signed-off-by: Ryan Moats <rmo...@us.ibm.com> > > > > Hi Ryan. > > > > In the "full" cases, if ports or multicast groups have disappeared, what > > deletes the associated flows? > > > > Thanks, > > > > Ben. > > > > That's an excellent question - Since those are created and removed by > northd (if I read the code right), right now, we'll have stale entries > until the next time we need full logical flow processing, at which > point we'll dump the desired flow table and flush them out. > > Since I don't really like that answer, I think code that addresses > this case would be useful. I propose to put it in a follow-on patch set, > since I don't think it quite fits here.
Thanks for answering. I agree that it's related but different, so I pushed this. Thanks for being persistent with improving the incremental update code now that it's in. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev