> On Jul 29, 2016, at 11:06 AM, Ben Pfaff <b...@ovn.org> wrote:
> 
> On Thu, Jul 28, 2016 at 05:55:53PM -0700, Jarno Rajahalme wrote:
>> Separate rule versioning to lib/versions.h to make it easier to use
>> versioning for other data types.
>> 
>> Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
> 
> I wish this wasn't called "versions", because that sounds like the
> version of Open vSwitch, but I don't have a really good name.
> 

I struggled with this myself. We could call it "table_versions" but the we 
might one day use it also for port configuration, for example.

Other possibility would be to call these "configuration versions" "generations" 
- I believe this term is used elsewhere with similar meaning.

> I think that it would be a good idea to add a top-level explanatory
> comment to versions.h that explains what it is and how one would use
> it.  The functions and data structures in versions.h could also use
> brief comments.
> 

I'll add these.

> Acked-by: Ben Pfaff <b...@ovn.org>
> 

Thanks!

  Jarno
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to