I changed the fc_conf initialization to use memset, because clang was complaining about the initializer.
I moved the description in vswitch.xml to avoid nesting inside the "Common Columns" group. I changed slightly the wording in vswitch.xml, in case we want to implement this even for non DPDK devices. I added your name to AUTHORS and pushed this to master Thanks! Daniele 2016-07-28 13:36 GMT-07:00 Chandran, Sugesh <sugesh.chand...@intel.com>: > Thank you Bhanu for reviewing and testing it. > > > Regards > _Sugesh > > > > -----Original Message----- > > From: Bodireddy, Bhanuprakash > > Sent: Thursday, July 28, 2016 4:54 PM > > To: Chandran, Sugesh <sugesh.chand...@intel.com>; diproiet...@ovn.org; > > dev@openvswitch.org > > Subject: RE: [PATCH v2] netdev-dpdk: Add Flow Control support. > > > > >-----Original Message----- > > >From: Chandran, Sugesh > > >Sent: Thursday, July 28, 2016 4:30 PM > > >To: diproiet...@ovn.org; Bodireddy, Bhanuprakash > > ><bhanuprakash.bodire...@intel.com>; dev@openvswitch.org > > >Cc: Chandran, Sugesh <sugesh.chand...@intel.com> > > >Subject: [PATCH v2] netdev-dpdk: Add Flow Control support. > > > > > >Add support for flow-control(mac control frame) to DPDK enabled physical > > >port types. By default, the flow-control is OFF on both rx and tx side. > > >The flow control can be enabled/disabled either when adding a port to > OVS > > or > > >at run time. > > > > > >For eg: > > >To enable flow control support at tx side while adding a port, add the > 'tx- > > flow- > > >ctrl' option to the 'ovs-vsctl add-port' command-line as below. > > > > > > 'ovs-vsctl add-port br0 dpdk0 -- \ > > > set Interface dpdk0 type=dpdk options:tx-flow-ctrl=true' > > > > > >Similarly to enable rx flow control, > > > 'ovs-vsctl add-port br0 dpdk0 -- \ > > > set Interface dpdk0 type=dpdk options:rx-flow-ctrl=true' > > > > > >And to enable the flow control auto-negotiation, 'ovs-vsctl add-port > br0 > > >dpdk0 -- \ > > > set Interface dpdk0 type=dpdk options:flow-ctrl-autoneg=true' > > > > > >To turn ON the tx flow control at run time(After the port is being > added to > > >OVS), the command-line input will be, 'ovs-vsctl set Interface dpdk0 > > >options:tx-flow-ctrl=true' > > > > > >The flow control parameters can be turned off by setting 'false' to the > > >respective parameter. To dsiable the flow control at tx side, > 'ovs-vsctl set > > >Interface dpdk0 options:tx-flow-ctrl=false' > > > > > >Signed-off-by: Sugesh Chandran <sugesh.chand...@intel.com> > > > > LGTM, I tested it and can apply the rx flow control setting even when the > > interface is transmitting. > > Acked-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> > > > > Regards, > > Bhanu Prakash. > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
