"dev" <[email protected]> wrote on 07/29/2016 05:26:29 PM:
> From: Chandra Sekhar Vejendla/San Jose/IBM@IBMUS > To: [email protected] > Date: 07/29/2016 05:26 PM > Subject: [ovs-dev] [PATCH v3] ovn: Support for GARP for NAT IPs via localnet > Sent by: "dev" <[email protected]> > > In cases where a DNAT IP is moved to a new router or the SNAT IP is reused > with a new mac address, the NAT IPs become unreachable because the external > switches/routers have stale ARP entries. This commit > aims to fix the problem by sending GARPs for NAT IPs via locanet > > A new options key "nat-addresses" is added to the logical switch port of > type router. The value for the key "nat-addresses" is the MAC address of the > port followed by a list of SNAT & DNAT IPs. > > Signed-off-by: Chandra Sekhar Vejendla <[email protected]> One nit that I saw: [snip] > @@ -891,7 +973,19 @@ send_garp_run(const struct ovsrec_bridge > *br_int, const char *chassis_id, > const struct sbrec_port_binding *pb = lport_lookup_by_name (lports, > iface_id); > if (pb) { > - send_garp_update(pb, &localnet_ofports, local_datapaths); > + send_garp_update(pb, &localnet_ofports, local_datapaths, > + &nat_addresses); > + } > + } > + > + /* Update send_garp_data for nat-addresses */ Add a period at the end of the comment. with that nit addressed... Acked-by: Ryan Moats <[email protected]> _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
