"dev" <dev-boun...@openvswitch.org> wrote on 08/08/2016 11:14:14 AM:

> From: Ben Pfaff <b...@ovn.org>
> To: dev@openvswitch.org
> Cc: Ben Pfaff <b...@ovn.org>
> Date: 08/08/2016 11:15 AM
> Subject: [ovs-dev] [PATCH v2 03/21] expr: Fine-tune parser error
> message for common typo.
> Sent by: "dev" <dev-boun...@openvswitch.org>
>
> It's easy to type "=" in place of "==" in an expression but the
expression
> parser's error message was far from clear.  For multibit numeric fields,
> it said:
>     Explicit `!= 0' is required for inequality test of multibit field
>     against 0.
> For string fields, the parser treated such an expression as "<name> != 0"
> and thus it said:
>     String field <name> is not compatible with numeric constant.
>
> This improves the error message in each case to:
>     Syntax error at `=' expecting relational operator.
> which I hope to be clear.
>
> Signed-off-by: Ben Pfaff <b...@ovn.org>
> ---

I'm pretty much always a sucker for better error messages...

Acked-by: Ryan Moats <rmo...@us.ibm.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to