On Mon, Aug 08, 2016 at 12:29:42PM -0500, Ryan Moats wrote:
> "dev" <dev-boun...@openvswitch.org> wrote on 08/08/2016 11:14:28 AM:
>
> > From: Ben Pfaff <b...@ovn.org>
> > To: dev@openvswitch.org
> > Cc: Ben Pfaff <b...@ovn.org>
> > Date: 08/08/2016 11:17 AM
> > Subject: [ovs-dev] [PATCH v2 17/21] meta-flow: New functions
> > mf_subfield_copy() and mf_subfield_swap().
> > Sent by: "dev" <dev-boun...@openvswitch.org>
> >
> > The function nxm_execute_reg_move() was almost a general-purpose function
> > for manipulating subfields, except for its awkward interface that took a
> > struct ofpact_reg_move instead of a plain source and destination. This
> > commit introduces a general-purpose function in meta-flow that corrects
> > this flaw, and updates the callers. An upcoming commit will introduce a
> > new user of the function.
> >
> > This commit also introduces a related function mf_subfield_swap() to swap
> > the contents of subfields. An upcoming commit will introduce the first
> > user.
> >
> > Signed-off-by: Ben Pfaff <b...@ovn.org>
> > ---
>
> I've acked up to patch set 12, but patch sets 13 through 16 didn't
> make it to my mailbox...
>
> After applying patch set 14, I'm getting the following error when trying
> to build:
>
> ovn/lib/actions.c: In function 'encode_CT_LB':
> ovn/lib/actions.c:1043:28: error: format '%u' expects argument of type
> 'unsigned int', but argument 3 has type 'size_t {aka long unsigned int}'
> [-Werror=format=/b]
>
> ... I'm thinking the arg in the string needs ao change
Oops. I applied patches 1 through 12, fixed that up in #14, and posted
v3.
Thanks a lot for all the reviews!
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
