Ben Pfaff <b...@ovn.org> wrote on 08/14/2016 10:06:41 PM:

> From: Ben Pfaff <b...@ovn.org>
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/14/2016 10:06 PM
> Subject: Re: [ovs-dev, v2] ovn-controller: Remove flows created for
> now deleted SB database rows.
>
> On Fri, Aug 12, 2016 at 09:35:07AM -0500, Ryan Moats wrote:
> > Ensure that rows created for deleted port binding and
> > multicast group rows are cleared when doing full processing.
> >
> > Signed-off-by: Ryan Moats <rmo...@us.ibm.com>
> > ---
> > v1->v2:
> >   - replace use of ssets for storing UUIDs as strings with hmaps for
> >     storing the UUID structs themselves
> >   - include an optimization suggested by Ben when reviewing v1
>
> I'm pretty sure that this leaks all of the nodes removed from the hmap
> by hmap_clear(new) in rationalize_hmap_and_delete_flows().
>

Oh, am I red-faced!

The comment after the new commit message in the new PS says it all...
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to