> On Sep 13, 2016, at 11:14 AM, Ben Pfaff <b...@ovn.org> wrote:
> 
> On Mon, Sep 12, 2016 at 01:52:33PM -0700, Jarno Rajahalme wrote:
>> Timing out idle bundles frees memory that would effectively be leaked
>> if a long standing OpenFlow connection would fail to commit or discard
>> a bundle.
>> 
>> OpenFlow specification mandates the timeout to be at least one second,
>> if the switch implements such a timeout.  This patch makes the bundle
>> idle timeout to be 10 seconds.
>> 
>> We do not limit the number of messages in a bundle, so it does not
>> make sense to limit the number of bundles either, especially now that
>> idle bundles are timed out.
>> 
>> Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
>> ---
>> v3: New patch for v3.
> 
> It would be kind to describe the behavior in ovs-vswitchd(8), in the
> OPENFLOW IMPLEMENTATION section (and then the code should refer back to
> this so that we'll update it if we change the code).
> 

Done, thanks for the review. Will push to master (only?) soon.

  Jarno


> Acked-by: Ben Pfaff <b...@ovn.org>

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to